simplemvvmtoolkit Issue Tracker Rss Feed

Closed Issue: Redundant type parameter in DelegateCommand.ConvertParameter? [278]

tonysneed — Thu, 16 May 2013 11:25:30 GMT

Dear Tony,

first of all, thanks for providing this excellent and simple MVVM library.

I needed to re-build the software from the sources, since I require a strong name on the assembly. When building the Silverlight solution, the assembly is built, but I get the following warning message:

Type parameter 'T' has the same name as the type parameter from outer type 'SimpleMvvmToolkit.DelegateCommand<T>'

If I look at the ConvertParameter method to which the warning message is attributed, it has the following signature:

private T ConvertParameter<T>(object parameter)

Correct me if I am wrong, but isn't the <T> redundant? The code would be clearer if the signature would read:

private T ConvertParameter(object parameter)

A very minor issue, but maybe worth fixing anyway?

Best regards,
Anders

Closed Issue: Type conversion bug in DelegateCommand.ConvertParameter [324]

tonysneed — Thu, 16 May 2013 11:25:29 GMT

Hi Tony,

this line in method DelegateCommand<T>.ConvertParameter<TOutput>()...

if (parameter.GetType() == typeof(TOutput))

...should be...

if (parameter is TOutput)

Otherwise an InvalidCastException is erroneously thrown when the actual CommandParameter is of a type *derived* from TOutput.

Regards,
Chris

Closed Issue: WP7.1 EventToCommand cannot be added to a collection or dictionary of type 'TriggerActionCollection' [342]

tonysneed — Thu, 16 May 2013 11:25:29 GMT

On WP7.1 Beta2 and Wp7.1 Beta2 Refresh(with final API) i get the following error:
A value of type 'EventToCommand' cannot be added to a collection or dictionary of type 'TriggerActionCollection'.

Rebuilding the wp7 source (with or without upgrading the project to wp7.1 ) is not helping.

On the following code the mvvm:EventToCommand throws the error , the ei:CallMethodAction part is working. In other parts of my project i nedd to pass the event args to the command, thats why i need this to work. Please help.

<i:Interaction.Triggers>
<i:EventTrigger EventName="Loaded">
<mvvm:EventToCommand
Command="{Binding PageLoadedCommand}"/>

</i:EventTrigger>
<i:EventTrigger EventName="Unloaded">
<ei:CallMethodAction
TargetObject="{Binding}"
MethodName="PageUnloaded"/>
</i:EventTrigger>
</i:Interaction.Triggers>

Thanks

Closed Issue: WCF RIA Services Project Download URL Not Found [466]

tonysneed — Thu, 16 May 2013 11:25:28 GMT

Hi Tony,

I'd tried to download the WCF RIA Services project but the page cannot be found:
http://tonysneed.com/simplemvvm/SimpleMvvmRiaServices.zip

Frankie

Closed Issue: Unable to create SimpleMVVMRiaServices project for Visual Studio 2010 SP1 [475]

tonysneed — Thu, 16 May 2013 11:25:28 GMT

I have Visual Studio 2010 SP1 installed, thereby many of the original prerequisites for the SimpleMVVM Toolkit irrelevant.

I was able to install all other required prerequisites, however, and thereby able to view the Visual Studio project templates.

But, when I attempt to create my SimpleMVVMRiaServices project in Visual Studio by selecting the installed Project Template, I get the following error message:

"A problem was encountered creating the sub project: SimpleMvvmRiaServices.Test. The imported project Microsoft.Silverlight.Toolkit.Build.targets was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk."

Closed Issue: ViewModelDetailBase.IsDirty not reliable [476]

tonysneed — Thu, 16 May 2013 11:25:27 GMT

Synopsis: ViewModelDetailBase.IsDirty might return false even if the Model has been altered due to hash collision in ModelExtensions.AreSame() resp. ModelExtensions.GetObjectHashCode(). ModelExtensions.AreSame violates it's contract "True if object properties are the same".
see [discussion:287271]

Closed Issue: A first chance exception of type 'System.NullReferenceException' occurred in SimpleMvvmToolkit-WP7.dll [511]

tonysneed — Thu, 16 May 2013 11:25:27 GMT

I'm creating an application with the Windows Phone 7.1 SDK. I'm using version 3.0 of SimpleMVVM toolkit.

I'm calling NotifyPropertyChanged in the setter of an observable collection in one of my viewmodels. It is a collection of one of my model classes. The first time the page is displayed everything goes well. But when I navigate back to this page from another page I get a NullReferenceException when the collection changes.

I debugged some more and I found out that the exception occurs on line 57 of GenericDelegateCommand :
string exceptionMessage = string.Format("Cannot convert {0} to {1}", parameter.GetType(), typeof(T));

Apparently parameter is null at this point and that is why the exception occurs. There is a check for null on line 81 so in some cases parameter can be null? What could be the reason why it is null? I don't see how I can do something wrong in my code by just calling NotifyPropertyChanged in the setter.

Closed Issue: MVVM template does not show in installed templates [604]

tonysneed — Thu, 16 May 2013 11:25:27 GMT

I believe I have the prerequisites for installing the toolkit. I am only doing WPF projects, however. I do not see the mvvm template when I try to create a new project. Am I missing something?
Thanks
Mark

Closed Issue: UIDispatcher only executes actions asynchronously. [629]

tonysneed — Thu, 16 May 2013 11:25:26 GMT

I have need of executing an action on the UI thread synchronously. I would like to use the UIDispatcher for simplicity, but currently the only option is the Execute() method that operates asynchronously. Please add another method to UIDispatcher to execute an action synchronously. An example is:

public static void ExecuteSynchronously(Action action)
{
if (dispatcher.CheckAccess()) action();
else dispatcher.Invoke(action);
}

Thank you!

Closed Issue: IsInDesignMode doesn't work into WinForms [651]

tonysneed — Thu, 16 May 2013 11:25:26 GMT

The IsInDesignMode-Property doesn't work if you create a Control in WPF and use it in a WinForms-Application.

Closed Issue: Issue with the event bus notification message [712]

tonysneed — Thu, 16 May 2013 11:25:26 GMT

I have a viewmodel through which I am sending a message to the event bus. I am using something like
SendMessage(MessageTokens.ExtractionRunning, new NotificationEventArgs<bool>(null, this.isBusy));

There are two separate viewmodel who have registered to receive the message. When the message is sent the first time both the viewmodels receive the message correctly. However, when the message is sent the second time, only one of the two viewmodels receive the message and that too twice.

The code used to register to receive the messages is
RegisterToReceiveMessages<bool>(MessageTokens.ExtractionRunning, OnFileExtractionRunning);

The above appears to be a bug to me

Closed Issue: Sign assemblies with a strong name ... [725]

tonysneed — Thu, 16 May 2013 11:25:25 GMT

... otherwise it is not possible to use the toolkit from a signed exe.

Closed Issue: Issue with GenericDelegateCommand.ConvertParameter [753]

tonysneed — Thu, 16 May 2013 11:25:25 GMT

I have the following XAML associated with a command (associated with a ListBox)

<i:Interaction.Triggers>
<i:EventTrigger EventName="SelectionChanged">
<i:InvokeCommandAction Command="{Binding AddItem}"
CommandParameter="{Binding SelectedItem, ElementName=items}" />
</i:EventTrigger>
</i:Interaction.Triggers>

This when clearing the ListBox selected item the command is fired with a parameter of null. This is turn causes an exception in GenericDelegateCommand.ConvertParameter at the following line

string exceptionMessage = string.Format("Cannot convert {0} to {1}",
parameter.GetType(), typeof(T));

I think the correct code should have the following at the start of the method

if ( parameter == null )
{
return default(T);
}

What do you think?

Closed Issue: DataContract on ModelBase Needs IsReference = True [1143]

tonysneed — Thu, 16 May 2013 11:25:25 GMT

The DataContract attribute on ModelBase should have the IsReference property set to True. This will prevent cycles in derived classes when they are serialized.

Closed Issue: Toolkit v4.0.0.0 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1213]

franczc — Thu, 16 May 2013 11:25:24 GMT

Hi Tony,

I'm having problem in installing the latest toolkit version. I logged in to the PC as administrator. Please see the attach error message. I tried manually delete the specified dll file from the folder (which should prove that I have the access to the folder??) and rerun the installer, but the same error message showed up again.

I also tried run the installer using the "Run as administrator" option but it didn't help.

Closed Issue: Toolkit v3 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1422]

liangyanhe — Thu, 16 May 2013 11:25:23 GMT

Failed both on Win 2003 R2 SP1 and Windows 7

Commented Issue: Toolkit v3 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1422]

liangyanhe — Mon, 01 Apr 2013 08:12:15 GMT

Failed both on Win 2003 R2 SP1 and Windows 7
Comments: ** Comment from web user: liangyanhe **

Hi
On the Windows Xp, ,.NET Framework 4.5 can't be installed, can you release Toolkit v3 for xp? think you.

Commented Issue: Toolkit v3 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1422]

tonysneed — Tue, 19 Mar 2013 13:18:57 GMT

Failed both on Win 2003 R2 SP1 and Windows 7
Comments: ** Comment from web user: tonysneed **

Try right-clicking the installer and selecting "Run As Administrator".

I will put together a manual installation process that you can use if the installer still fails for some people.

I do have some people who have volunteered to help with the project, so I believe someone will create a WIX installer at some point, which will eliminate unnecessary dependencies created by InstallShield.

Commented Issue: Toolkit v4.0.0.0 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1213]

franczc — Sun, 10 Mar 2013 23:29:37 GMT

Hi Tony, the new installer worked fine for me too. Thanks a lot for the fix!

Commented Issue: Toolkit v3 installation failed with error writing to file Microsoft.VisualBasic.Activities.Compiler.dll [1422]

praveen_jsr — Fri, 01 Mar 2013 10:18:27 GMT

Failed both on Win 2003 R2 SP1 and Windows 7
Comments: ** Comment from web user: praveen_jsr **

I downloaded the latest version but the issue still persists .